Fix ComponentEditorWidget ignoring derived types #165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where custom component editors only worked with exact type matches and did not support derived types or interfaces. The fix implements a scoring system based on inheritance distance to select the most appropriate editor, with exact matches receiving the best score.
Changes:
- Introduced a scoring system to match component editors based on type inheritance hierarchy
- Added support for derived component types and interfaces
- Changed editor selection from exact name matching to inheritance-based scoring
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Custom component editors only work if the type is an exact match. It has no support for derived component types.
Facepunch/sbox-issues#9822
Fix
I've made it use a simple scoring system to find the best editor.
The score given is based on the inheritance distance with exact matches being the best.
It also now supports interfaces as targets.